Skip to content

fix: Markdown breaking issue between hyperlinks#1260

Closed
Giridharan002 wants to merge 4 commits intoRocketChat:mainfrom
Giridharan002:main
Closed

fix: Markdown breaking issue between hyperlinks#1260
Giridharan002 wants to merge 4 commits intoRocketChat:mainfrom
Giridharan002:main

Conversation

@Giridharan002
Copy link

@Giridharan002 Giridharan002 commented Jan 10, 2024

Proposed changes (including videos or screenshots)

This pull request addresses an issue where typing between two hyperlinks in Rocket.Chat causes the markdown to break. This happens even without a space or other separator between the hyperlinks and the inserted text.
properly converts:
[Rocket.Chat] [New release](https://www.rocket.chat/blog/new-starter-pro-plans) to html like this <p>[Rocket.Chat] <a href="https://www.rocket.chat/blog/new-starter-pro-plans">New release</a></p>

Issues

closes the issue:
RocketChat/Rocket.Chat#31766
RocketChat/Rocket.Chat#31418

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4bfc923

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLAassistant commented Jan 10, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

This was referenced Jan 10, 2024
Closed
Closed
@Giridharan002
Copy link
Author

Giridharan002 commented Apr 4, 2024

@dougfabris, could you please take a moment to review the PR when you're available, Thank you!

@Giridharan002
Copy link
Author

Giridharan002 commented Apr 5, 2024

@MartinSchoeler could you please review the PR if you have some time, thanks

marceloschmidt
marceloschmidt reviewed Jul 9, 2025
View reviewed changes
Copy link
Member

@marceloschmidt marceloschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Giridharan002 I apologize for the lack of contact here.
I was looking at your pull request and wondered why did you create an unnest function, import it, then not use it?

Copilot AI mentioned this pull request Feb 12, 2026
Merged
@ggazzo ggazzo closed this Feb 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marceloschmidt marceloschmidt marceloschmidt left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Giridharan002 @CLAassistant @marceloschmidt @ggazzo